Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Allow populates to use select/omit for singular associations #1615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[patch] Allow populates to use select/omit for singular associations #1615

wants to merge 1 commit into from

Conversation

danielsharvey
Copy link

Currently the populates clause is allowed for plural ("collection")
associations but disallowed for singular ("model") associations.

This patch allows only a select or an omit for singular associations.

@danielsharvey
Allow populates to use select/omit for singular associations
176b1c2 
Currently the populates clause is allowed for plural ("collection")
associations but disallowed for singular ("model") associations.

This patch allows only a select or an omit for singular associations.
@danielsharvey
Copy link
Author

danielsharvey commented Apr 9, 2020 •
edited
Loading

I have reviewed the code, run the tests and tested within my own use cases.

Are there other tests that should be run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielsharvey